Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect params serialisation for EthGetBlockReceipts #5131

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 13, 2025

Summary of changes

Changes introduced in this pull request:

  • fixes deserialization issue in EthGetBlockReceipts. The main fix comes from using Deserialize_tuple internally, but it's more maintainable to simply import the correct data structure.
api-compare-1  | | RPC Method                               | Forest                                                                | Lotus      |
api-compare-1  | |------------------------------------------|-----------------------------------------------------------------------|------------|
api-compare-1  | | Filecoin.EthGetBlockReceipts (3)         | Rejected("Fallback deserialization failed: Eof. Original error: Eof") | Valid      |
api-compare-1  | | Filecoin.EthGetBlockReceipts (9)         | CustomCheckFailed                                                     | Valid      |
api-compare-1  | | Filecoin.EthGetBlockReceipts (88)        | Valid                                                                 | Valid      |

⬇️

api-compare-1  | | RPC Method                         | Forest            | Lotus |
api-compare-1  | |------------------------------------|-------------------|-------|
api-compare-1  | | Filecoin.EthGetBlockReceipts (41)  | CustomCheckFailed | Valid |
api-compare-1  | | Filecoin.EthGetBlockReceipts (759) | Valid             | Valid |

Reference issue to close (if applicable)

Part of #5006

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the fix-serialization-error-eth-get-block-rceipts branch 2 times, most recently from d33848d to e1eab8d Compare January 13, 2025 18:50
@LesnyRumcajs LesnyRumcajs force-pushed the fix-serialization-error-eth-get-block-rceipts branch from e1eab8d to 129b055 Compare January 13, 2025 18:50
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 13, 2025 19:03
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 13, 2025 19:03
@LesnyRumcajs LesnyRumcajs requested review from lemmih and sudo-shashank and removed request for a team January 13, 2025 19:03
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 67ff65d Jan 13, 2025
48 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-serialization-error-eth-get-block-rceipts branch January 13, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants