feat(tool): dump RPC tests to a directory #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
LesnyRumcajs and
sudo-shashank
and removed request for
a team
sudo-shashank
requested changes
Dec 10, 2024
sudo-shashank
approved these changes
Dec 10, 2024
Comment on lines
+1955
to
+1956
| #[allow(clippy::type_complexity)] | ||
| fn format_as_markdown(results: &[((Cow<'static, str>, TestSummary, TestSummary), u32)]) -> String { |
There was a problem hiding this comment.
Can we avoid suppressing the lint with some limited amount of type?
There was a problem hiding this comment.
Yes, let me tackle this in a follow up PR.
LesnyRumcajs
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Part of #5047
The next step is, implementing
forest-tool api generate-test-snapshot [TEST_DUMP] --db [PATH], instead of introducing invasive logic to forest daemon like on https://github.com/ChainSafe/forest/tree/hm/dump-rpc-tests branch.Changes introduced in this pull request:
--dump-diroption toforest-tool api compareCLI commandTestDumpto be serializableReference issue to close (if applicable)
Closes
Other information and links
Change checklist