-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return null in MinerGetBaseInfo
if miner hasn't been around for 900 epochs
#4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
ruseinov and
LesnyRumcajs
and removed request for
a team
September 30, 2024 12:14
LesnyRumcajs
approved these changes
Sep 30, 2024
@lemmih In general, can we synthesize a test that would fail without this change? This is to ensure the behaviour doesn't change by chance in the future. |
Testing it using one of the devnets is possible in theory but rather tricky. It'll be much easier once we have #4657. |
ruseinov
approved these changes
Sep 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 1, 2024
Oof, more intermittent networking errors. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 2, 2024
The CI just doesn't want this PR to be merged and finds plethora of excuses. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
null
to match Lotus' behavior.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist