Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return null in MinerGetBaseInfo if miner hasn't been around for 900 epochs #4820

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Sep 30, 2024

Summary of changes

Changes introduced in this pull request:

  • If a miner isn't found in the look-back state, we must return null to match Lotus' behavior.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review September 30, 2024 12:14
@lemmih lemmih requested a review from a team as a code owner September 30, 2024 12:14
@lemmih lemmih requested review from ruseinov and LesnyRumcajs and removed request for a team September 30, 2024 12:14
@LesnyRumcajs
Copy link
Member

@lemmih In general, can we synthesize a test that would fail without this change? This is to ensure the behaviour doesn't change by chance in the future.

@lemmih
Copy link
Contributor Author

lemmih commented Sep 30, 2024

Testing it using one of the devnets is possible in theory but rather tricky. It'll be much easier once we have #4657.

@ruseinov ruseinov added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 30, 2024
@ruseinov ruseinov added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 30, 2024
@lemmih lemmih added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@ruseinov ruseinov added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 1, 2024
@lemmih
Copy link
Contributor Author

lemmih commented Oct 1, 2024

Oof, more intermittent networking errors.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 2, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@LesnyRumcajs
Copy link
Member

The CI just doesn't want this PR to be merged and finds plethora of excuses. :)

@lemmih lemmih added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit a875e3d Oct 2, 2024
38 checks passed
@lemmih lemmih deleted the lemmih/get-base-info-edge-case branch October 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants