-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upload corresponding latest snapshot sha256sum #441
Conversation
Signed-off-by: samuelarogbonlo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's enumerate the files to be uploaded rather than using a wildcard.
Signed-off-by: samuelarogbonlo <[email protected]>
updated, @lemmih what do you think ? |
You're still using a wildcard rather than enumerating the files. We only want to upload the archive and checksum files. Any other files in that directory should not be uploaded. |
@lemmih Looking at https://github.com/ChainSafe/forest-iac/blob/main/cf/prune-latest/src/index.ts, it seems that adding corresponding checksum files would decrease the number of recent snapshots by half. Are we okay with that? Or should that worker be updated accordingly? |
If the Infra team is ready to take over then we don't have to worry about retention. Let's see what Josh at the meeting later today. If they need more time, we'll bump our retention (which is still quite a bit lower than required by the contract, iirc). |
Forest snapshot service discontinued in favour of the infra snapshot service. |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
part #370
Other information and links