nits: validate terraform snapshot_type input

Signed-off-by: samuelarogbonlo <[email protected]>

tf-managed/modules/daily-snapshot/service/init.sh

@@ -24,13 +24,13 @@ bash newrelic_fail2ban.sh
 # Setup cron job
 case "$SNAPSHOT_TYPE" in
     mainnet)
-        cp mainnet_cron_job /etc/cron.hourly/ && rm calibnet_cron_job
+        mv mainnet_cron_job /etc/cron.hourly/
         ;;
     calibnet)
-        cp calibnet_cron_job /etc/cron.hourly/ && rm mainnet_cron_job
+        mv calibnet_cron_job /etc/cron.hourly/
         ;;
     both)
-        cp calibnet_cron_job mainnet_cron_job /etc/cron.hourly/
+        mv calibnet_cron_job mainnet_cron_job /etc/cron.hourly/
         ;;
     *)
         echo "Error: Invalid SNAPSHOT_TYPE. Please specify 'mainnet', 'calibnet', or 'both'."

tf-managed/modules/daily-snapshot/variable.tf

@@ -111,11 +111,17 @@ variable "environment" {
 
 
 variable "snapshot_type" {
-  description = "The type of snapshot the node should generate. Options are 'mainnet', 'calibnet', or 'both'."
-  default     = "both"
-  type        = string
+  type        = list(string)
+  description = "List of network types for snapshot generation. Valid options: 'mainnet', 'calibnet'."
+  default     = ["both"]
+
+  validation {
+    condition     = alltrue([for val in var.snapshot_type : contains(["mainnet", "calibnet", "both"], val)])
+    error_message = "Only 'mainnet', 'calibnet', or 'both' are allowed for snapshot_type."
+  }
 }
 
+
 # Monitoring properties of the service. Can be declared partially.
 variable "monitoring" {
   description = "Service monitoring properties"