Skip to content

Add work decomposition and the oversized-PR gate - #123

Merged
kalambet merged 1 commit into
mainfrom
peter/work-decomposition
Aug 14, 2026
Merged

Add work decomposition and the oversized-PR gate#123
kalambet merged 1 commit into
mainfrom
peter/work-decomposition

Conversation

@kalambet

Copy link
Copy Markdown
Member

Description

Adds two concepts the handbook was missing: a model for decomposing planned work into tracked units, and a gate for changes that outgrow what a reviewer can absorb.

1 of 2 in a stack. This PR carries the new normative content. [PR 2] threads cross-references from the existing pages into it and asserts nothing new. Merge this one first.

What changed

  • New page — workflows/work-decomposition.md. Defines epic → milestone → bite-sized issue by what each level guarantees: an epic is one recognizable outcome carrying the plan artifact, a milestone leaves main releasable, an issue is closed by exactly one PR. Gives six tests for "bite-sized" and maps plan.md phases and tasks onto the tracker.
  • chainsafe-research-plan-implement skill. Pipeline becomes research → plan → annotate → decompose → implement. New Phase 3b produces the breakdown inside plan.md for operator approval; Phase 4 gains the one-issue-one-PR rule; two key rules added; description gains decomposition triggers.
  • Gate §10 in gates-and-escalation.md. Covers PRs that cannot be reviewed in one pass, close more than one issue, bundle concerns, or outgrow the approved plan slice. Cleared by proposing a split or by an explicit operator approval recorded in the PR description. Agents never self-approve. Escalation-matrix row added.
  • llms.txt — new page entry, updated workflow-skill description, gate count corrected.

The handbook said PRs should be small and that agents stay inside
operator-named scope, but nothing made either enforceable. There was no
model for breaking planned work into tracked units, and no gate for a
change that outgrew what a reviewer can absorb. A PR is only as small as
the issue behind it, and that issue had nowhere to come from.

Two concepts, both new normative content:

- Work decomposition. workflows/work-decomposition.md defines
  epic -> milestone -> bite-sized issue by what each level guarantees:
  an epic is one recognizable outcome, a milestone leaves main
  releasable, an issue is closed by exactly one PR. Six tests for
  "bite-sized", and an explicit mapping from plan.md phases and tasks
  onto the tracker. The research-plan-implement skill gains a Decompose
  phase so the breakdown is produced and approved before implementation
  starts, plus two key rules.

- Gate 10. Covers PRs that cannot be reviewed in one pass, close more
  than one issue, bundle concerns, or outgrow the approved plan slice.
  Cleared by proposing a split, or by an explicit operator approval
  recorded in the PR description. Agents never self-approve.

The standard is deliberately reviewability, not a line count. Line
thresholds are easy to satisfy and easy to game, so the bar is the
handbook's existing ~10-minute one-reviewer-one-pass test. The
rename/deletion/generated-code exemption is kept but narrowed to
scope-width only: a large rename is fine, a rename plus a logic change
is two PRs.

llms.txt is updated in this commit per the same-PR index rule in
mcp-and-llm-txt.md. That also corrects the gate count, which read
"Eight" while nine already existed.

Cross-references from pr-authoring, code-review, repo-and-ci-setup, the
invariants, and the mirror skills follow in the next PR of this stack.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@kalambet kalambet self-assigned this Aug 12, 2026

@dhyaniarun1993 dhyaniarun1993 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to the reviewer skills as well

@dhyaniarun1993

Copy link
Copy Markdown
Member

We should add this to the reviewer skills as well

Looks like this is covered in #124

@kalambet

Copy link
Copy Markdown
Member Author

@dhyaniarun1993 yes, I wanted to split the PRs in two so they are more of a bite-sized :)

@kalambet
kalambet merged commit 9a8b162 into main Aug 14, 2026
2 of 4 checks passed
@kalambet
kalambet deleted the peter/work-decomposition branch August 14, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants