New Feature: "Contracts" => enable/disable contract integration tests #80
+69
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nulltea
requested changes
Oct 18, 2024
contracts/src/lib.rs
Outdated
| @@ -0,0 +1 @@ | |||
| // replace this crate with the actual contracts crate to run integration tests | |||
| let vk: &VerifyingKey<G1Affine> = pk.get_vk(); | ||
|
|
||
| let circuit_params = circuit.params(); | ||
| //let vk_serialized = vk.to_bytes(halo2_base::halo2_proofs::SerdeFormat::RawBytes); |
There was a problem hiding this comment.
what about this commented code?
There was a problem hiding this comment.
I guess PR is still WIP, lmk if so
There was a problem hiding this comment.
That was included by accident, I removed it now :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change that helps satisfy
rust-analyzerwhen cloning the spectre repo and opening it in an IDE.I introduce a dummy crate with a readme pointing to the real contracts crate and a
featurethat makes the dependency on contract integration tests optional.I believe that this is an improvement to the workspace since we can't push the compiled binaries to GitHub and we want developers to be able to isolate and test / work on the ZK logic without having to bother setting up Smart Contracts / pulling in the external crate.
@nulltea agrees to my proposal which is why I have decided to create this PR. Please comment for suggestions and further improvements :).