Avoid unexpected infinity when aggregating pub keys #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If a bad
r
is sampled and used to initiate an accumulator, then the resultingagg_pubkey - r
could be the point at infinity, which would likely result in the signature validation failing. However, this is a very unlikely scenario.Fix
Aggregate from
PK[0]
instead of random point. Though sinceparticipation[0]
couldfalse
we need to setQuestion
Is it safe to use identity? The halo2lib API actually prohibits implicitly assigning identity as constant, though allows it as a witness.