Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Balance display should not show the token and should not format the amount #462

Merged
merged 16 commits into from
Dec 11, 2023

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 10, 2023

closes #461
Only some very specific calls should have the balance displayed nicely with the token and the amount of decimals. Check the changes in constants.ts to see which ones. These will be nice in the manual extrinsics and in the call info, while all others should be in plank.

You can watch 7J9rSWpjfQjSYr1QDKPr6KjhnC2b2kLWfyBTiTpMgkNvD7vr on Hydra and see in prod how it shows HDX wrongly, and on this branch it doesn't.

Edit: Ok I added a some tests to check that

  • the displayed value of an extrinsic not in the list is in plank
  • the input value for the same, is also in plank
  • the input value for an extrinsic in this list is in the denominated token.
  • the display value, for an extrinsic in the list, is in HDX (from call data since it's using the same component as the transaction list)

@Tbaut Tbaut changed the base branch from main to asnaith/unknown-transaction-test December 11, 2023 14:39
@Tbaut
Copy link
Collaborator Author

Tbaut commented Dec 11, 2023

Ok I added some tests to check that

  • the displayed value of an extrinsic not in the list is in plank
  • the input value for the same, is also in plank
  • the input value for an extrinsic in this list is in the denominated token
  • the display value, for an extrinsic in the list, is in HDX (from call data since it's using the same component as the transaction list)

Base automatically changed from asnaith/unknown-transaction-test to main December 11, 2023 17:23
@Tbaut Tbaut merged commit 20b2fad into main Dec 11, 2023
7 checks passed
@Tbaut Tbaut deleted the tbaut-not-always-balance branch December 11, 2023 21:28
@asnaith
Copy link
Member

asnaith commented Dec 11, 2023

Nice fix and tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The main token with decimal formating is displayed for unrelated asset transfer
3 participants