Support proxy.killPure #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deployed a v2 of the squid, but some network fail for some obscure reasons (hence the tests failing too). It's testable locally, but not on the preview yet. I'll update when this is fixed, I'm in contact with the Subsquid team. |
|
ok it should be good now |
|
Looks good. I compared prod and this branch with the accounts that you provided (thanks!) . I was able to see the fix working :) |
asnaith
approved these changes
Nov 22, 2023
Lykhoyda
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #284
This shouldn't be a dangerous change, it's fixing a bug that very few ppl may have encountered.
I've tested it with the example from the original issue where watching for
5ForHKSnt3Cy96RFssfh8PSkA3uq9YBFgFMzwzfvjyCDdmkbnow doesn't show the pure that was killed ( this one, visible in prod5H2zstd4qCPjjNP7qQ5du3jEVSUDZUZKbgKjZxxMyFgZyP1e)Also I've created and killed a pure almost right away, if you watch
5CACqqjMZUXEZsWFNETS3SWMmX85HMG6THF6EeQw43KjHcYYon Rococo it shouldn't give you anything.5GnXakTjcrL8UJDd7QUrHXd7211U7c97Ydnq4ojBJghwJT6X^ this one is also visible in prod, erroneously.