Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "connect" button blue and change the copy a bit #411

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Oct 18, 2023

closes #389

There's 1 case when we have 2 buttons primary on a page, but it's doing the same thing, so I guess it's ok.

  • Connect and Connect wallet buttons are now blue
  • Change the copy "Watch One" -> "Wach address" since the "one" we're referring to makes no sense, one what, wallet?
  • "Connect extension" to "Connect wallet" to be future proof if we want to use WalletConnect or anything else

I used this opportunity to refactor the Home that was having a lot of duplicate code. This means please check that the correct messages are displayed when they should (BTW let's make a test for this, edit: #412)

  • Multix welcome message when brand new landing
  • No account found when clicking on connect without an extension
  • No multisig found when an account is shared in the extension but there's no msig and watched address is empty

image
image
image

Submission checklist:

Layout

  • Change inspected in the desktop web ui
  • Change inspected in the mobile web ui

Compatibility

  • Functionality of change validated with a connected account with multisig
  • Applicable elements hidden / disabled for watched multisigs / pure

Copy link
Collaborator

@Lykhoyda Lykhoyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@asnaith
Copy link
Member

asnaith commented Oct 19, 2023

Left one little suggestion for consistency but other than that looks great.

The appropriate message is displayed for all of the scenarios listed.

@Tbaut Tbaut merged commit c23862f into main Oct 19, 2023
4 checks passed
@Tbaut Tbaut deleted the tbaut-primary-connect branch October 19, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the "connect" button of variant "primary"
3 participants