Use name registry in recipients list #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lykhoyda
reviewed
Oct 19, 2023
| withAccountsFromAddressBook: boolean | ||
| } | ||
|
|
||
| export const useAccountBaseFromAccountList = (params?: Params) => { |
There was a problem hiding this comment.
can we use here object destruction?
({ withAccountsFromAddressBook = false }: Params) => There was a problem hiding this comment.
This is what I usually prefer too, but in this case, it doesn't allow Param to be undefined. I wanted to keep Params | undefined so as not to change anything in the useAccountBaseFromAccountList calls that are happening elsewhere. And because we can't destructure an undefined object, and afaik there's also no way to say something like Param | undefined and at the same time set { withAccountsFromAddressBook = false } as default value.. that's why I went for this.
Lykhoyda
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #395
How to test:
In New tx > Send tokens
In the "to" field you'll have the addresses from your name registry too.