Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Arrow-squid #393

Merged
merged 20 commits into from
Nov 7, 2023
Merged

Move to Arrow-squid #393

merged 20 commits into from
Nov 7, 2023

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Oct 10, 2023 •
edited
Loading

closes #372

  • There should be no change in the interface, or actually anything. It's purely a backend upgrade that should be transparent.
  • 90% of the diff is auto-generated here, such as everything in squid/src/types
  • some RPCs from onFinality were unresponsive
  • I merged the chopsticks PR into this one because Chopsticks needed Arrow-squid, and both PRs in parallel was more annoying than anything. Right now there's a config file for Chopstick that will be used when we close Experiment running our own fork of any network in the CI with Chopsticks #394

@Tbaut
Copy link
Collaborator Author

Tbaut commented Nov 7, 2023

I'm moving Joystream to RPC, takes a little while to sync, ~2h but there will be an archive in the next weeks.

@Tbaut Tbaut requested review from Lykhoyda and asnaith November 7, 2023 14:23
@Tbaut Tbaut marked this pull request as ready for review November 7, 2023 14:23
Lykhoyda
Lykhoyda reviewed Nov 7, 2023
View reviewed changes
squid/src/main.ts Outdated Show resolved Hide resolved
Lykhoyda
Lykhoyda approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Lykhoyda Lykhoyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please consider the scenario when we have no event data if it works as expected

@Tbaut
Copy link
Collaborator Author

Tbaut commented Nov 7, 2023

I don't understand what you mean. see my answer to you comment.

@Lykhoyda
Copy link
Collaborator

Lykhoyda commented Nov 7, 2023

I don't understand what you mean. see my answer to your comment.

It was before I saw your comment. All good 🙌

asnaith
asnaith approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multisigs I checked were all viewable as expected

Looks good to go :)

@Tbaut Tbaut merged commit 907445c into main Nov 7, 2023
5 checks passed
@Tbaut Tbaut deleted the tbaut-arrow-squid branch November 7, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lykhoyda Lykhoyda Lykhoyda approved these changes

@asnaith asnaith asnaith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tbaut @Lykhoyda @asnaith