Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update navbar active link #377

Merged
merged 4 commits into from
Sep 29, 2023
Merged

feat: update navbar active link #377

merged 4 commits into from
Sep 29, 2023

Conversation

Lykhoyda
Copy link
Collaborator

@Lykhoyda Lykhoyda commented Sep 29, 2023 •
edited
Loading

Closes #302

  • add NavLink component
  • Replaced RouterLink in Navbar
  • Update mobile navigation
  • Re-arrange nav links (About in the end)

@Lykhoyda Lykhoyda requested a review from Tbaut September 29, 2023 10:54
Tbaut
Tbaut approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is spot on, thank's a lot!

@Tbaut Tbaut merged commit 9bbef06 into main Sep 29, 2023
6 checks passed
@Tbaut Tbaut deleted the lykhoyda/active_navbar branch September 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add indication of the current selected menu in nav bar
2 participants
@Lykhoyda @Tbaut