Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress can now sign programmatically #367

Merged
merged 16 commits into from
Sep 29, 2023
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Sep 26, 2023

closes #357

  • can sign/reject Txs
  • can see the transactions queue and analyze the payload

todo:

  • tests will fail if a tx is the same as one that's in the queue so we need to clean pending TXs first if we want to see the whole flow. I'll do this in another PR, when approving/rejecting pending TXs.

@Tbaut Tbaut requested a review from Lykhoyda September 26, 2023 15:28
Copy link
Collaborator

@Lykhoyda Lykhoyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good considering the accept transaction will be handled in the next PR. I requested some changes for code duplication.

packages/ui/cypress/tests/transactions.cy.ts Show resolved Hide resolved
packages/ui/cypress/tests/transactions.cy.ts Outdated Show resolved Hide resolved
packages/ui/cypress/tests/transactions.cy.ts Show resolved Hide resolved
packages/ui/src/components/Toasts/ToastContent.tsx Outdated Show resolved Hide resolved
@Tbaut
Copy link
Collaborator Author

Tbaut commented Sep 28, 2023

The accept transaction is definitely working, but under some specific conditions. I'm on the fence between:

  • fixing it in the issue I mentioned ([Cypress] Add helper to reject any pending multisig Tx #370)
    or
  • actually do it right from the get go (in a separate issue as well), and go with a full setup including forking the network with Chopsticks, running an indexer against this fork, start with a blank page every single test, test the multisig creation flow, and signing a TX. This would probably be ideal, but non trivial, and the sequence in which tests will be run will matter.

@Tbaut Tbaut merged commit 7bcb997 into main Sep 29, 2023
6 checks passed
@Tbaut Tbaut deleted the tbaut-cypress-sign-programmatically branch September 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cypress] Allow to sign transactions
2 participants