-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Header styles #366
Update Header styles #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The background of the main app is
#FAFCFD
afaics from the design. Only the menu (and some components are#fff
orwhite
also on this, it's quite rare in design to use pure white/black. Let me catch up on that with Cindy. In the mean time, we can use white/black cf https://graphicdesign.stackexchange.com/questions/25356/why-not-use-pure-black-000-and-pure-white-fff -
Some elements like a loader are invisible now, there's a loader there usually. I believe it is
color: ${({ theme }) => theme.palette.primary.main};
-
Having a horizontal scrollbar and the dropdown for Networks cut is worse than having the menu on 2 lines IMHO. We should implement this only after Rework the network dropdown #264
-
Let's try not to use
black
orwhite
in the code directly, and rather use the theme.palette colors so that we can change them quickly.
The background color is probably not updated everywhere, please provide the link next time if there is a original version of the design. |
The link is in the original issue, pointing to a figma node that has been deleted in the mean time... Feel free to ask then. However the figma with this view is still there, and the screenshot in the original issue is also quite clear. On top of this there's a mention of "updating the background to the right gray". Doing my best to have well scoped issues, but at some point I can't do much more. |
ddbb625
to
28c483c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great thanks a lot!
Closes #260
updates: