Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Header styles #366

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Update Header styles #366

merged 4 commits into from
Sep 27, 2023

Conversation

Lykhoyda
Copy link
Collaborator

@Lykhoyda Lykhoyda commented Sep 26, 2023

Closes #260

  • Updated navbar background
  • logo update
  • fix navbar elements to jump to the next line
  • fix colors, hover
  • renamed Header component

updates:

  • Fixed the gray background color of the page
  • Logo color
  • Watch the account navigation link for ConnectOrWatch component

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lykhoyda
Copy link
Collaborator Author

The background color is probably not updated everywhere, please provide the link next time if there is a original version of the design.
2) I agree that is not ideal, but as I said it shouldn't affect the users as screen size is not common. Let's have 2 lines if it's "better" 😃

@Tbaut
Copy link
Collaborator

Tbaut commented Sep 26, 2023

The background color is probably not updated everywhere, please provide the link next time

The link is in the original issue, pointing to a figma node that has been deleted in the mean time... Feel free to ask then. However the figma with this view is still there, and the screenshot in the original issue is also quite clear. On top of this there's a mention of "updating the background to the right gray". Doing my best to have well scoped issues, but at some point I can't do much more.

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks a lot!

@Tbaut Tbaut merged commit f7d55e4 into main Sep 27, 2023
6 checks passed
@Tbaut Tbaut deleted the lykhoyda/navbar_update branch September 27, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu bar style colors change
2 participants