Bump UI dependancies #360
Bump UI dependancies #360
Conversation
packages/ui/src/index.tsx
Outdated
| <StrictMode> | ||
| <RouterProvider router={router} /> | ||
| </StrictMode> | ||
| ) as any |
There was a problem hiding this comment.
@Lykhoyda if you've an idea how to remove this, that'd be appreciated.. I sounds like the render isn't happy with the return of the StrictMode.. although this dep hasn't actually changed.
There was a problem hiding this comment.
@Tbaut StictMode should stay in place, it helps with the development. Can you please provide the error output that you are facing?
There was a problem hiding this comment.
Right, I never meant to change the strict mode. The error is
Argument of type 'Element' is not assignable to parameter of type 'ReactNode'.
This error needs context though, it seems that the issue is from react-router-dom. You can check it out by just removing the as any. I'm on the fence between the any or downgrading react-router-dom.. having a hard time finding a good answer.
There was a problem hiding this comment.
spent too much time on this.. I really don't know where it originates from. typescript and react-router-dom rollback doesn't help. I'd just merge as is.
There was a problem hiding this comment.
@Tbaut looks like it was not able to detect react types automatically, so I added the path to tsconfig. Please check if it works for you
There was a problem hiding this comment.
Thanks a lot for checking it out. Your fix worked, and pointed me in the direction that we actually don't even need the @types/react. Removing it solved the issue too 🤷♂️
@testing-library/cypress