Repository navigation
six of seven launchpads drew initials, and four had a file already - #3577
Merged
Merged
Conversation
Bench 318 shows an initials chip for every row but Stonk.fun. Four of the six already had a brand mark sitting in public/logos that nothing pointed at: the slug on that bench is `pumpfun` and the manifest entry beside it is `pump-fun`, so one hyphen was the whole bug. Same for `pons-family` against `pons`. LetsBonk and BONK.fun are one mark, checked rather than assumed before putting one company's logo on another's row: letsbonk.fun serves /logos/bonk_fun.png as its own icon, and the file already here is that dog with the bat, cropped. One brand, one file, no new asset. ArgusPad and Flap had nothing, so each one's own declared icon was taken: Argus' 180 px apple-icon and Flap's 32 px icon.svg, both verified to be a mark and not a wordmark before landing. long-xyz is deliberately left on its chip. long.xyz answers 403 to every path, the page and each icon, from this machine and from its subdomains, and going around a site's own block to take its logo is not something to do quietly. No cache key: logo-manifest resolves in ProviderLogo at render time and never enters a cached payload. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bench 318 (
launchpad-wars) shows an initials chip for every row but Stonk.fun, in production.Four were an alias gap, not a missing file
pumpfunpump-funpump-fun.jpgpons-familyponspons.webpletsbonkbonk-funbonk-fun.webpOne hyphen was the whole bug on the first two.
LetsBonk and BONK.fun are one mark, and that was checked rather than assumed before putting one company's logo on another's row: letsbonk.fun serves
/logos/bonk_fun.pngas its own icon, and the file already here is that dog with the bat, cropped. One brand, one file, no new asset.Two needed fetching
Each one's own declared icon, verified to be a mark and not a wordmark before landing: Argus' 180 px
apple-icon(10 KB PNG) and Flap's 32 pxicon.svg(1.5 KB, a path).One is deliberately left on its chip
long-xyz. long.xyz answers 403 to every path — the page and each icon, from this machine and fromapp.,www.anddocs.— and going around a site's own block to take its logo is not something to do quietly. The comment in the manifest says so, so the next person does not re-litigate it.Noticed while doing this, not fixed here
/products/pumpfunand/products/pump-funboth return 200 with the identical title, "pump.fun: trading benchmark 2026, live rank". That is the duplicate-product-page failurePRODUCT_ALIASESexists to prevent, and whose own comment records the last time it happened.pons/pons-familyandletsbonk/bonk-funalso both resolve, with different titles, so whether those are one product or two is a judgement I am not making alone. Folding a slug changes product pages and search presence and wantsproviders-vmoved with it.No cache key
logo-manifestresolves inProviderLogoat render time and never enters a cached payload.pnpm exec tsc --noEmitclean ·pnpm test1077 pass 0 fail ·pnpm lint0 errors.Reaching production
This bench is live on openchainbench.com, so the logos appear on staging at merge and on prod at the next
devtomainrelease.🤖 Generated with Claude Code