-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CAIP - Block Addressing model #220
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promi
|
||
``` | ||
block_address: chain_id + ":block/" + account_address + ["." + property]? | ||
chain_id: [-a-z0-9]{3,8}:[-_a-zA-Z0-9]{1,32} (See [CAIP-2][]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to repeat the definition of chain_id
in all documents that use it? Wouldn't just linking to it be enough? I see that otherwise managing all occurrences might be hell.
``` | ||
block_address: chain_id + ":block/" + account_address + ["." + property]? | ||
chain_id: [-a-z0-9]{3,8}:[-_a-zA-Z0-9]{1,32} (See [CAIP-2][]) | ||
block_height: [-%a-zA-Z0-9]{1,128} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has been superseded by the property
field?
Blocks are addressed as follows: | ||
|
||
``` | ||
block_address: chain_id + ":block/" + account_address + ["." + property]? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is account_address
defined?
block_address: chain_id + ":block/" + account_address + ["." + property]? | ||
chain_id: [-a-z0-9]{3,8}:[-_a-zA-Z0-9]{1,32} (See [CAIP-2][]) | ||
block_height: [-%a-zA-Z0-9]{1,128} | ||
property (optional): (hash|height|time|nonce|prev|txncount|data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about aliasing? For some chains, hash
and height
can be used interchangeably. So we would have to different identifiers for the same resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the semantics of this enum, and more importantly the valid SUBSET of it, would be defined per-namespace in profiles, right? that's a really good shout-out, i should update the normative text to make this more explicit.
Co-authored-by: Antonio <[email protected]>
No description provided.