Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include for specific UE 5.3 builds #1476

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

csciguy8
Copy link
Contributor

@csciguy8 csciguy8 commented Jul 8, 2024

Came up in the forum here

[1/4] Compile [x64] CesiumGlobeAnchorCustomization.cpp
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(239): error C2664: 'bool IsValid(const UObject *)': cannot convert argument 1 from 'ACesiumGeoreference *' to 'const UObject *'
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(239): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
C:\toolchains\unreal\ue-5.3.2-release\Engine\Source\Runtime\CoreUObject\Public\UObject\Object.h(1771): note: see declaration of 'IsValid'
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(239): note: while trying to match the argument list '(ACesiumGeoreference *)'
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(278): error C2664: 'bool IsValid(const UObject *)': cannot convert argument 1 from 'ACesiumGeoreference *' to 'const UObject *'
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(278): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
C:\toolchains\unreal\ue-5.3.2-release\Engine\Source\Runtime\CoreUObject\Public\UObject\Object.h(1771): note: see declaration of 'IsValid'
C:\path\to\project\Plugins\CesiumForUnreal\Source\CesiumEditor\Private\CesiumGlobeAnchorCustomization.cpp(278): note: while trying to match the argument list '(ACesiumGeoreference *)'

@csciguy8 csciguy8 marked this pull request as ready for review July 8, 2024 19:48
@csciguy8
Copy link
Contributor Author

csciguy8 commented Jul 8, 2024

Tried to reproduce locally on Windows 10, UE 5.3.2, but was not successful. Downloading the released plugin and forcing it to build produced a working project.

However, I was able to verify these same problems via Visual Studio's Intellisense. Including this header make the squiggles go away.

image

@j9liu
Copy link
Contributor

j9liu commented Jul 10, 2024

Thanks @csciguy8 !

@j9liu j9liu merged commit 03e3818 into main Jul 10, 2024
26 checks passed
@j9liu j9liu deleted the fix-ue53-plugin-compile branch July 10, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants