Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on debug assertions #1464

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Turn on debug assertions #1464

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d81d177
Force assertions on for debug builds
csciguy8 Jun 27, 2024
f6384b4
Update cesium-native
csciguy8 Jun 27, 2024
22dd673
Merge remote-tracking branch 'origin/main' into turn-on-debug-assertions
kring Jul 26, 2024
59da934
Enable assertions in multi-config generators, too.
kring Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extern/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ set(CMAKE_MSVC_RUNTIME_LIBRARY MultiThreadedDLL)
set(CMAKE_INSTALL_PREFIX ${CMAKE_CURRENT_LIST_DIR}/../Source/ThirdParty)
set(CMAKE_INSTALL_LIBDIR ${CMAKE_INSTALL_PREFIX}/lib/${CMAKE_SYSTEM_NAME}-x${CESIUM_ARCHITECTURE})

# Always define this, since Unreal does in debug anyway
# We don't want any mismatches, especially with class member ordering
add_compile_definitions(NDEBUG)
# Always define NDEBUG, since Unreal does in debug anyway.
# We don't want any mismatches, especially with class member ordering.
# But still let debug builds force assertions.
add_compile_definitions(NDEBUG $<$<CONFIG:Debug>:CESIUM_FORCE_ASSERTIONS>)

set(CESIUM_DEBUG_POSTFIX "d")
set(CESIUM_RELEASE_POSTFIX "")
Expand Down