Use rotation from globe anchor in CesiumFlyToController #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the very late, completely out-of-context post, but what was the reason for the change to use a parent? Is there a reason you can't use a |
|
Ignore the above. We talked about this offline and I opened #434 for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that got overlooked in changing CesiumFlyToController to be able to use a parent CesiumGlobeAnchor. Instead of using the local transform, we want to use the rotation of whatever transform the CesiumGlobeAnchor is attached to for the source rotation on our flight, since this is the object that the rotation is going to be applied to as it flies.