Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detangle CesiumCameraController from CesiumFlyToController #434

Open
j9liu opened this issue Mar 14, 2024 · 0 comments
Open

Detangle CesiumCameraController from CesiumFlyToController #434

j9liu opened this issue Mar 14, 2024 · 0 comments
Labels
quality Improve code quality or encourage developer success

Comments

@j9liu
Copy link
Contributor

j9liu commented Mar 14, 2024

The changes in #422 raise some implications about our current component design that I think we should consider, to improve code quality and clarity.

While working with XR, @azrogers found a scenario where:

  • The XR origin needed to be anchored by CesiumGlobeAnchor, but
  • The camera is a child game object that will contain CesiumCameraController and CesiumFlyToController.

It feels conceptually strange that the CesiumFlyToController is piloting a parent object, or more generally some object that it isn't actually attached to. Historically we have attached it to a camera in order to make it fly between locations, but we should look to decouple this from CesiumCameraController. Cesium for Unreal does this and also seems to account for movement interruption, so maybe we can take the implementation from there.

There may be more design implications to consider, but I can't remember completely what we discussed offline. @azrogers feel free to weigh in if I missed anything!

@j9liu j9liu added the quality Improve code quality or encourage developer success label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve code quality or encourage developer success
Projects
None yet
Development

No branches or pull requests

1 participant