Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing button for adding imagery from Asset UI #711

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

r-veenstra
Copy link
Contributor

Closes #701

The Use as Terrain Tileset Base Layer button was missing from the assets UI when selecting an imagery asset to add

Two issues were present

Firstly, the self._asset_type needed to be checking for IMAGERY when checking if the button should be created in asset_details_widget.py

Secondly, is_tileset was being passed a prim instead of a prim path, which caused the function to fail

The button is now visible, and successfully adds to either the first tileset found in the selection, the first tileset in the stage if no selection is present, or creates a new Cesium World Terrain tileset if no tilesets are found.

image

@lilleyse
Copy link
Contributor

Thanks @r-veenstra

@lilleyse lilleyse merged commit 0ccc365 into main Apr 29, 2024
3 checks passed
@lilleyse lilleyse deleted the fix-add-imagery branch April 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use as Terrain Tileset Base Layer button missing
2 participants