Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tile Map Service (TMS) and Web Map Tile Service (WMTS) raster overlay support #691

Merged
merged 9 commits into from
Feb 21, 2024

Conversation

corybarr
Copy link
Contributor

@corybarr corybarr commented Feb 16, 2024

(Draft until UI polishing is complete)


Adds TMS support:

image

Adds WMTS support:

image


UI/UX Notes:

  • If a parameter is not relevant based on another set value, Unreal will gray those options out:

image

This PR hides them instead. I didn't find an obvious way to gray them out.

  • In Unreal, "Tile Matrix Set Labels" is an array of strings:
    image

While Omniverse supports string[] parameters, they aren't by default editable in the UI:
image

In this PR, users supply the strings comma-separated.

  • I don't have an example to test all settings. "Tiling Scheme Settings" is currently untested:
    image

  • I hit some limitations trying to visually group parameters in the custom attribute widgets. In particular omni.ui.Line didn't appear. The UI is functional, but the UX and in particular visual groupings could use improvement.

  • reloading the tileset every time a property is changed is probably not ideal. See Spec and implement improved UI/UX for refreshing and reloading tilesets and raster overlays #676

@r-veenstra
Copy link
Contributor

This appears to be functioning as expected.

My only question is should there be some feedback in the console when WMTS is configured incorrectly?

For example, with WMS and TMS if I put in a wrong URL, I'll usually get some form of error.

However, with WMTS nothing displays in the log at all.

@corybarr corybarr marked this pull request as ready for review February 21, 2024 04:28
@corybarr
Copy link
Contributor Author

corybarr commented Feb 21, 2024

This appears to be functioning as expected.

My only question is should there be some feedback in the console when WMTS is configured incorrectly?

For example, with WMS and TMS if I put in a wrong URL, I'll usually get some form of error.

However, with WMTS nothing displays in the log at all.

I think it would be better. I'll look into it.

For ref, it seems that a valid, although empty, result is returned when WMTS Urls are bad:
image

A bad TMS Url will fail the if (result) test and trigger the error logger.

Copy link
Contributor

@lilleyse lilleyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't do much testing beyond loading the .usda files and trying out the new UI but the code looks consistent with WMS.

@corybarr corybarr merged commit 36b7ba9 into main Feb 21, 2024
3 checks passed
@corybarr corybarr deleted the add-tms-and-wmts-raster-overlay branch February 21, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants