Raster overlay UI/UX enhancements #649

corybarr · 2024-01-30T11:02:35Z

Adds custom UI widgets for CesiumPolygonRasterOverlayPrim and CesiumIonRasterOverlayPrim
Adds "Invert Selection" to CesiumPolygonRasterOverlayPrim
Makes CesiumPolygonRasterOverlayPrim and CesiumIonRasterOverlayPrim "alpha" attribute a slider
Makes BasisCurves created via Quick-Add menu have appropriate settings for type, wrap, and points attributes.
Sets ordering of UI groups to match Unreal (polygons->invert->rendering->credits)
Constrains cartographic polygon bindings to only be BasisCurves

Resolves #633
Resolves #618
Resolves #631

…clip

…nto raster-overlay-ui-enhancements

src/core/src/OmniPolygonRasterOverlay.cpp

exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py

exts/cesium.omniverse/cesium/omniverse/ui/attributes/ion_raster_overlay_attributes_widget.py

lilleyse · 2024-01-30T22:34:44Z

exts/cesium.omniverse/cesium/omniverse/ui/attributes/ion_raster_overlay_attributes_widget.py

+            def _build_slider(
+                stage,
+                attr_name,
+                metadata,
+                property_type,
+                prim_paths: List[Sdf.Path],
+                additional_label_kwargs={},
+                additional_widget_kwargs={},
+            ):
+                from omni.kit.window.property.templates import HORIZONTAL_SPACING
+                from omni.kit.property.usd.usd_attribute_model import UsdAttributeModel
+                from omni.kit.property.usd.usd_property_widget import UsdPropertiesWidgetBuilder
+
+                if not attr_name or not property_type:
+                    return
+
+                with ui.HStack(spacing=HORIZONTAL_SPACING):
+                    model_kwargs = UsdPropertiesWidgetBuilder.get_attr_value_range_kwargs(metadata)
+                    model = UsdAttributeModel(
+                        stage,
+                        [path.AppendProperty(attr_name) for path in prim_paths],
+                        False,
+                        metadata,
+                        **model_kwargs,
+                    )
+                    UsdPropertiesWidgetBuilder.create_label(attr_name, metadata, additional_label_kwargs)
+                    widget_kwargs = {"model": model, "min": 0.0, "max": 1.0}
+                    widget_kwargs.update(UsdPropertiesWidgetBuilder.get_attr_value_soft_range_kwargs(metadata))
+
+                    if additional_widget_kwargs:
+                        widget_kwargs.update(additional_widget_kwargs)
+                    with ui.ZStack():
+                        value_widget = UsdPropertiesWidgetBuilder.create_drag_or_slider(
+                            ui.FloatDrag, ui.FloatSlider, **widget_kwargs
+                        )
+                        mixed_overlay = UsdPropertiesWidgetBuilder.create_mixed_text_overlay()
+                    UsdPropertiesWidgetBuilder.create_control_state(
+                        value_widget=value_widget, mixed_overlay=mixed_overlay, **widget_kwargs
+                    )
+                    model.add_value_changed_fn(lambda m, s=stage, p=prim_paths: update_range(s, p))
+
+                    return model


Is it possible to make this more generic and put in a helper file so it's not duplicated across files? E.g. I imagine the min/max values would be provided as options instead of hardcoded.

OK. Pushed. You can now call CustomLayoutProperty("cesium:alpha", build_fn=build_slider(0, 1)) with whichever values you want.

There might be a more Pythonic way to do this (with partial?) but this feels OK. I'm not yet fluently Pythonic, and some of my Python I've been told is like transliterated game-engine C++. This is literally transliterated game-engine C# code: [Range(0,1)].

exts/cesium.usd.plugins/schemas/cesium_schemas.usda

lilleyse · 2024-01-30T22:51:48Z

This doesn't need to be addressed now...

If I set a polygon overlay's render method to overlay it appears red. Is this something we have control over, or are we just rendering the pixel color exactly as it comes from native?

corybarr · 2024-01-30T23:05:37Z

This doesn't need to be addressed now...

If I set a polygon overlay's render method to overlay it appears red. Is this something we have control over, or are we just rendering the pixel color exactly as it comes from native?

We don't have control over it right now, but it's not a major lift. I created a ticket for it. #652

r-veenstra · 2024-01-31T05:03:49Z

Invert selection appears to obey the initial setting on load, but when changing the bool and refreshing the tileset it does not update accordingly. If I save the USDA with the updated bool and reload the stage, it works as expected.
Default values for the cartographic polygons appear to be good
Changing Invert Selection should probably trigger a tileset refresh (similar to the refresh that occurs when adding or removing polygons from the raster overlay). Though that could be frustrating unless Refresh tileset should not re-download tile data #650 is fixed first

You should be able to test the invert issue with the following zip

TilesetClipping.zip

r-veenstra · 2024-01-31T05:38:18Z

Thanks, invert issues appear resolved now!

r-veenstra · 2024-01-31T06:23:31Z

I added basis_curves.GetCurveVertexCountsAttr().Set([4]) to the creation of basis curves, as without this property the curves never render, and the control points never show when trying to edit them

…esiumGS/cesium-omniverse into raster-overlay-ui-enhancements

src/core/src/OmniPolygonRasterOverlay.cpp

lilleyse · 2024-01-31T18:39:52Z

exts/cesium.omniverse/cesium/omniverse/ui/attributes/custom_attribute_widgets.py

+def _update_range(stage, prim_paths):
+    for path in prim_paths:
+        rasterOverlay = CesiumRasterOverlay.Get(stage, path)
+        attr = rasterOverlay.GetAlphaAttr()
+        current_value = attr.Get()
+        new_value = max(0, min(current_value, 1.0))
+        attr.Set(new_value)


Is it possible to not hardcode CesiumRasterOverlay? I imagine we'll want to use this widget for other prim types.

Also it's not clear to me how the min/max options that are passed to build_slider are getting set. Seems like 0 and 1 are still hardcoded in a couple places.

Ah, I'd left 0 and 1 in widget_kwargs. Gone now.

I was able to remove the dependency on CesiumRasterOverlay.

Note: There were issues operating on generic prims. For some reason, only class functions to access attributes would work (e.g., GetAlphaAttr) in event handlers. Fortunately, we don't need update_range anyways. It's cruft from an example where bounds and its associated attributes needed to be updated. We might possible run into this in the future if we want to do something like update bounds on generic prims.

…nto raster-overlay-ui-enhancements

…esiumGS/cesium-omniverse into raster-overlay-ui-enhancements

corybarr added 7 commits January 30, 2024 02:51

add custom ui widgets, invert selection, all slider

4479c07

formatting

3867ec0

maker ion raster overlay alpha a slider

72bd96c

set CesiumPolygonRasterOverlayPrims to have a default render mode of …

3663e12

…clip

formatting

98dffb7

set type, wrap, and points property on created cartographic BasisCurves

91166d9

python formatting

1c6e2fc

corybarr changed the title ~~Raster overlay UI enhancements~~ Raster overlay UI/UX enhancements Jan 30, 2024

corybarr added 5 commits January 30, 2024 04:29

constrain targets to pasis curves in polygon raster overlay ui

2728d8f

change order of groups in raster overlay ui

e799843

python formatting

cf6cd2d

fix issue with constrained targets in ion raster overlay ui

e629fe9

Merge branch 'main' of https://github.com/CesiumGS/cesium-omniverse i…

1d4f98b

…nto raster-overlay-ui-enhancements

corybarr marked this pull request as ready for review January 30, 2024 19:52

lilleyse reviewed Jan 30, 2024

View reviewed changes

exts/cesium.usd.plugins/schemas/cesium_schemas.usda Show resolved Hide resolved

corybarr added 2 commits January 30, 2024 15:40

use class-specific Get*Attr methods

0719738

add and use accessor for polygon raster overlay invert attribute

a55e0cc

corybarr added 2 commits January 30, 2024 21:19

make tileset update when invert is toggled in polygon raster overlay

f0de6a0

python formatting

70c8eaa

Set vertex count attr on basis curve so they render

c32f954

r-veenstra mentioned this pull request Jan 31, 2024

Clipping updates for 0.17.0 CesiumGS/cesium-omniverse-samples#14

Merged

corybarr added 3 commits January 31, 2024 09:07

create custom_attribute_widgets file

829ebad

allow build_slider to accept max and min arguments

8d7ec68

Merge branch 'raster-overlay-ui-enhancements' of https://github.com/C…

29fb1d8

…esiumGS/cesium-omniverse into raster-overlay-ui-enhancements

lilleyse reviewed Jan 31, 2024

View reviewed changes

corybarr added 3 commits January 31, 2024 10:47

remove debug variable

ea19abe

remove hard-coded max and min when creating widget_kwargs

f2034ac

remove dependency on raster overlays in custom slider widget

4ebb2f0

lilleyse approved these changes Jan 31, 2024

View reviewed changes

lilleyse and others added 3 commits January 31, 2024 15:19

Merge branch 'main' into raster-overlay-ui-enhancements

8d75c11

Merge branch 'main' of https://github.com/CesiumGS/cesium-omniverse i…

99e5179

…nto raster-overlay-ui-enhancements

Merge branch 'raster-overlay-ui-enhancements' of https://github.com/C…

d9f4b18

…esiumGS/cesium-omniverse into raster-overlay-ui-enhancements

lilleyse mentioned this pull request Jan 31, 2024

Make "Alpha" parameter for a CesiumImageryPrim a constrained slider #587

Closed

corybarr enabled auto-merge January 31, 2024 20:31

corybarr merged commit 2c9606b into main Jan 31, 2024
3 checks passed

corybarr deleted the raster-overlay-ui-enhancements branch January 31, 2024 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raster overlay UI/UX enhancements #649

Raster overlay UI/UX enhancements #649

corybarr commented Jan 30, 2024 •

edited

Loading

lilleyse Jan 30, 2024

corybarr Jan 31, 2024

lilleyse commented Jan 30, 2024

corybarr commented Jan 30, 2024

r-veenstra commented Jan 31, 2024

r-veenstra commented Jan 31, 2024

r-veenstra commented Jan 31, 2024

lilleyse Jan 31, 2024

corybarr Jan 31, 2024 •

edited

Loading

Raster overlay UI/UX enhancements #649

Raster overlay UI/UX enhancements #649

Conversation

corybarr commented Jan 30, 2024 • edited Loading

lilleyse Jan 30, 2024

Choose a reason for hiding this comment

corybarr Jan 31, 2024

Choose a reason for hiding this comment

lilleyse commented Jan 30, 2024

corybarr commented Jan 30, 2024

r-veenstra commented Jan 31, 2024

r-veenstra commented Jan 31, 2024

r-veenstra commented Jan 31, 2024

lilleyse Jan 31, 2024

Choose a reason for hiding this comment

corybarr Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

corybarr commented Jan 30, 2024 •

edited

Loading

corybarr Jan 31, 2024 •

edited

Loading