Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nvrtc from install step #502

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Remove nvrtc from install step #502

merged 4 commits into from
Oct 20, 2023

Conversation

lilleyse
Copy link
Contributor

Removing the code that installs nvrtc to exts/cesium.omniverse/bin since we aren't using nvrtc yet. Instead I'm going to add this code to #459.

corybarr
corybarr approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@corybarr corybarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this strategy makes sense.

@lilleyse lilleyse merged commit c24708b into main Oct 20, 2023
3 checks passed
@lilleyse lilleyse deleted the remove-nvrtc branch October 20, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corybarr corybarr corybarr approved these changes

@weegeekps weegeekps Awaiting requested review from weegeekps

@r-veenstra r-veenstra Awaiting requested review from r-veenstra

@mattelser mattelser Awaiting requested review from mattelser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilleyse @corybarr