Subtree buffer structure validation #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Additionally, I have added the subtree validation to the specs. Some details are described in #226 , but the tl;dr is:
specs/data/subtrees/. These had not been part of the specs (for reeasons mentioned in the linked issue). They could only be validated with the (internal)--subtreeSpecscommand line command.specs/data: TheSubtreeValidationSpecjust validates all these files (using the fixed subtree 'implicit tiling' structure that all of these files have!) and checks whether the proper validation messages are generated.This includes the check that the
validSubtreeNoBuffers.json(based on #312) does not generate any issues.