chore: add kaniko label to agents #1
Conversation
in our old setup we had a jdk8 agent labelled with `light-java` that was used by gestalt builds. according to @Cervator gestalt should work fine with jdk11, so I'm suggesting to add the `light-java` label to the new jdk11 agent so that gestalt builds can find an executor again.
|
I'm wondering if we can also add the |
|
Added changes to include the |
having one should be sufficient and it's probably better to use "light"/"heavy" and "java"/"sth else" separately from each other as they're different dimensions
jdrueckert
changed the title
|
After reconsideration we only need to add the |
| additionalAgents: | ||
| kanikoEight: | ||
| podName: kaniko-precached-jdk8 | ||
| customJenkinsLabels: "kaniko-precached-jdk8" | ||
| customJenkinsLabels: "kaniko-precached-jdk8 kaniko" | ||
| tag: latest-jdk8 |
There was a problem hiding this comment.
BSA mentioned that we don't need JDK8 for DestSol anymore, and I believe we also no longer need it for Terasology.
@Cervator are you aware of any other part of our projects that might still need JDK8? Otherwise I believe, we don't need a JDK8 agent anymore.
In our old setup we had a jdk8 agent labelled with
light-javaandkanikothat was used, amongst others, by gestalt and JenkinsAndroidAgent builds. Now we have a jdk11 agent as default and an additional jdk8 agent, neither of which has the afore-mentioned labels.As a result, build jobs on gestalt and JenkinsAndroidAgent cannot find an executor with the respective
light-javaorkanikolabel.The
light-javalabel was superseded by thelightlabel (which makes sense as light and java are two different dimensions), so we should not change this here, but instead adjust it on "consumer" side.The
kanikolabel, however, should be added to allow identifying kaniko executors, especially if we might add other executors in the future. Also it doesn't really cost anything to add another label, does it?Relates to MovingBlocks/gestalt#137
Relates to MovingBlocks/JenkinsAgentAndroid#3