[ENG-6292] Fixed stale registration moderation state race condition - #11852
Open
ihorsokhanexoft wants to merge 2 commits into
Open
[ENG-6292] Fixed stale registration moderation state race condition#11852ihorsokhanexoft wants to merge 2 commits into
ihorsokhanexoft wants to merge 2 commits into
Conversation
adlius
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-6292
Purpose
When a registration is approved by an admin, postcommit spam checks are run with a stale state of a registration. While admin is being updated a registration moderation state to ACCEPTED, postcommit spam checks process a stale version of the registration that has moderation_state=INITIAL. So if postcommit finishes execution after transaction handlers, it overrides already updated ACCEPTED value by the stale INITIAL state
If we revert .save logic in tasks.py, the new test starts failing as moderation state is updated to INITIAL because by default .save updates all fields