[ENG-10028] SHARE is not consistently indexing OSF content#11671
Open
mkovalua wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-6from
Open
[ENG-10028] SHARE is not consistently indexing OSF content#11671mkovalua wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-6from
mkovalua wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-6from
Conversation
adlius
requested changes
Apr 8, 2026
Collaborator
adlius
left a comment
adlius
left a comment
There was a problem hiding this comment.
One comment and some questions.
| recatalog(queryset, start_id, chunk_count, chunk_size) | ||
|
|
||
|
|
||
| def get_not_indexed_guids_for_resource_with_no_indexed_guid(resource_type: str, first_guid: bool = True): |
Collaborator
There was a problem hiding this comment.
The naming of the argument first_guid could be a bit more descriptive. How about something like only_oldest_guid?
| def mark_indexing_failed(self): | ||
| self.has_been_indexed = False | ||
| from addons.osfstorage.models import OsfStorageFile | ||
| if isinstance(self, OsfStorageFile): |
Collaborator
There was a problem hiding this comment.
Why doe we need special casing for OstStorageFile?
Comment on lines
+2570
to
+2571
| has_been_indexed = models.BooleanField(default=None, null=True, blank=True, db_index=True) | ||
| date_last_indexed = models.DateTimeField(null=True, blank=True) |
Collaborator
There was a problem hiding this comment.
Does it mean these two fields would only be populated for the objects that are indexed after this PR is released? What happen to the objects that were indexed before this PR is merged/released?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Content on the OSF is not consistently being SHARE indexed. Newly created content on the OSF does not seem to be consistently being automatically indexed in SHARE, some content seems to be indexed but other content is not. There does not seem to be any way to discern what content has been indexed vs not indexed . The inability of some content to be re-indexed in admin, this is causing significant issues for OSF users, their content is not Discoverable on the OSF.
Changes
Take code from the PR
#11631 to avoid so much merge conflicts to solve with new
pbs-26-6target branchSide Effects
QE Notes
CE Notes
Documentation