[ENG-9722] Expand File Picker for Registration Submissions#771
Merged
nsemets merged 6 commits intoCenterForOpenScience:feature/pbs-25-24from Nov 26, 2025
Merged
[ENG-9722] Expand File Picker for Registration Submissions#771nsemets merged 6 commits intoCenterForOpenScience:feature/pbs-25-24from
nsemets merged 6 commits intoCenterForOpenScience:feature/pbs-25-24from
Conversation
nsemets
reviewed
Nov 17, 2025
| } | ||
|
|
||
| getFilesWithoutFiltering(filesLink: string): Observable<FileModel[]> { | ||
| getFilesWithoutFiltering(filesLink: string, page = 1): Observable<{ files: FileModel[]; meta?: MetaJsonApi }> { |
Collaborator
There was a problem hiding this comment.
Use PaginatedData<FileModel[]> instead of Observable<{ files: FileModel[]; meta?: MetaJsonApi }>
Contributor
Author
There was a problem hiding this comment.
Observable<{ files: FileModel[]; meta?: MetaJsonApi }>
is used for other calls on pagination too
I think it is ok or what is purpose of changings?
Collaborator
There was a problem hiding this comment.
We need it to have correct types and avoid any issues in future.
nsemets
previously approved these changes
Nov 17, 2025
nsemets
approved these changes
Nov 26, 2025
nsemets
merged commit e48b124
into
CenterForOpenScience:feature/pbs-25-24
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When submitting a registration, users can attach files via a file picker field in the registration schema. However, this file picker currently only displays the first 10 files, which restricts access to additional files stored in the project and limits the user’s ability to select the appropriate file(s) for their submission.
Summary of Changes
implement pagination for registration files
update scrolling for registration files
accumulate files data results in state on pagination calls
Screenshot(s)
a7f8-f1be-4398-910a-9d0b3bb2abff.mp4
Side Effects
QA Notes