-
Notifications
You must be signed in to change notification settings - Fork 6
Review step for registration #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…to feat/238-draft-registrations-steps
…to feat/238-draft-registrations-steps
…to feat/238-draft-registrations-steps
…rForOpenScience/angular-osf into feat/238-draft-registrations-steps
…rForOpenScience/angular-osf into feat/238-draft-registrations-steps
|
||
if (this.showDateControl) { | ||
dateControl!.enable(); | ||
dateControl!.setValidators(Validators.required); // make date required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this comment?
provider: { | ||
data: { | ||
type: 'registration-providers', | ||
id: 'osf', // Assuming 'osf' is the default provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this comment?
const payload = { | ||
data: { | ||
type: 'registrations', | ||
attributes: { | ||
embargo_end_date: embargoDate, | ||
draft_registration: draftId, | ||
}, | ||
relationships: { | ||
registered_from: projectId | ||
? { | ||
data: { | ||
type: 'nodes', | ||
id: projectId, | ||
}, | ||
} | ||
: undefined, | ||
}, | ||
provider: { | ||
data: { | ||
type: 'registration-providers', | ||
id: 'osf', // Assuming 'osf' is the default provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try to move it to mapper.
No description provided.