-
Notifications
You must be signed in to change notification settings - Fork 71
Update RunCellpose to support v3 and v4 #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Need to add in functionality of if input file location is |
|
(Concurrent with merge into repo, we need to make official CellProfiler/RunCellpose Dockers for omnipose, v3, and v4) |
|
Awesomesauce!
Are the Dockerfiles in the repo up to date, aka can we just re-tag the images you've been using for testing? |
|
Yes, those are the Dockerfiles that I used to make my own Dockers that have been testing on so they should be good to go. |
|
Also, can you check if #269 is superceded by this, and/or if we should include it? thanks! |
|
This does not supersede #269 per se, but I have not ever successfully run with GPU using Docker with any version of RunCellpose. (I marked this PR as ready to review as we have a time crunch for getting it merged but was planning on filing an issue saying that it still needed GPU-Docker testing and potentially debugging) |
Can you let me know the names they are currently known as, so I can just re-tag rather than rebuild, at your convenience? Ty!
Ah, ok, I'll take a look if I can, otherwise we'll merge what we have and revisit later, thanks. |
|
|
|
@ErinWeisbart Merged, but question - any especial reason to have it be |
|
Sorry, should be |
mad props to @DavidStirling at glencoesoftware for his work on v3!