New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the stc parser #2201

Merged

ajtribick merged 1 commit into master from stc-refactor

Jun 12, 2024

Collaborator

ajtribick commented Jun 9, 2024

Fix handling of modification of individual RA/Dec coordinates
Detect cyclic OrbitBarycenter references
Detect missing magnitude, spectral type when converting Barycenter back to Star
Fix line number handling in Tokenizer
Allow Modify to remove OrbitBarycenter if RA/Dec/Position are specified

ajtribick force-pushed the stc-refactor branch 7 times, most recently from 4139aa6 to 3343a9c Compare

June 10, 2024 17:02


          Refactor the stc parser

c27e852

- Fix handling of modification of individual RA/Dec coordinates
- Detect cyclic OrbitBarycenter references
- Detect missing magnitude, spectral type when converting Barycenter back to Star
- Fix line number handling in Tokenizer
- Allow Modify to remove OrbitBarycenter if RA/Dec/Position are specified

ajtribick force-pushed the stc-refactor branch from 3343a9c to c27e852 Compare

June 10, 2024 17:52

sonarcloud bot commented Jun 10, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ajtribick marked this pull request as ready for review

June 10, 2024 19:00

375gnu approved these changes

View reviewed changes

ajtribick merged commit 6a1b6b7 into master

9 checks passed

ajtribick deleted the stc-refactor branch

June 12, 2024 16:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment