Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace models in integration tests, fix ASCII writer for UB4 attributes #2198

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Replace models in integration tests, fix ASCII writer for UB4 attributes #2198

merged 1 commit into from
Jun 7, 2024

Conversation

ajtribick
Copy link
Collaborator

  • Remove models with unclear license
  • Use test CMOD file with a wider selection of attributes
  • Use simple icosphere model to test 3DS loader

@ajtribick
Copy link
Collaborator Author

On hold pending #2199 to workaround vcpkg build failure

@ajtribick ajtribick marked this pull request as ready for review June 7, 2024 16:47
@ajtribick
Replace models in integration tests, fix ASCII writer for UB4 attributes
2c9c78e 
- Remove models with unclear license
- Use test CMOD file with a wider selection of attributes
- Use simple icosphere model to test 3DS loader
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ajtribick ajtribick merged commit 9508342 into master Jun 7, 2024
9 checks passed
@ajtribick ajtribick deleted the test-models branch June 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@375gnu 375gnu 375gnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajtribick @375gnu