Show Earth's mass and show all semi-axes for non spherical bodies #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For spherical or mesh objects, Radius: [radius] For spheroids or ellipsoids, Radius: [mean] ([a] × [b] × [c])
|
I don't know how to compile so this is untested and likely needs some fixing, so I decided to make a pull request. |
Changed semiAxes[0] to semiAxes.x() and so on; assuming that semiAxes.y() is the polar semi-axis.
|
TODO:
|
{} -> {%.4g}
Previously, the 'default' else case shows triaxial radii; I figured that making this case show just one value is more future-proof.
ajtribick
requested changes
Jun 9, 2024
ajtribick
approved these changes
Jun 15, 2024
375gnu
reviewed
Jun 15, 2024
375gnu
reviewed
Jun 15, 2024
375gnu
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so Earth's mass is shown, considering that Jupiter's mass is also shown even if it simply appears as 1.000 MJ
Objects that are neither spherical or use mesh now show mean radius along with all three semi-axes, using the following format:
Radius: mean (a × b × c)
kg masses can now uses scientific notation if sufficiently large. No more 20,000,000,000,000,000,000 kg, just 2E+19 kg.