Handle orbitingStars when filtering in Qt Solar System Browser #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtribick
force-pushed
the
qt-filter-handle-orbitingstars
branch
from
b31bf46
to
d2be58d
Compare
375gnu
approved these changes
Jan 14, 2024
ajtribick
force-pushed
the
qt-filter-handle-orbitingstars
branch
from
d2be58d
to
23601ac
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2065 - this fixes the specific issue that the filter method does not handle multiple star systems (which for these purposes includes Sol, as the Sun is defined relative to the Solar System Barycentre).
There is still a lot of non-ideal behaviour in the filtering though, e.g. filtering for spacecraft will exclude all spacecraft that are not direct children of a star.