Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celestia splash screen #438

Open
SevenSpheres opened this issue Oct 8, 2019 · 28 comments
Open

Celestia splash screen #438

SevenSpheres opened this issue Oct 8, 2019 · 28 comments
Labels
question Further information is requested

Comments

@SevenSpheres
Copy link
Contributor

SevenSpheres commented Oct 8, 2019

In 2016 Alexell made a new Celestia splash image (last one in this post). Should it be used in version 1.7?

(Added three days later, put here for visibility)
Actually, why not add a line like this to celestia.cfg:
SplashImage "splash.png"
Then the user can choose what splash image they want without having to rename/replace any files.
Celestia could even install with multiple images for the user to choose from.

@375gnu 375gnu added the question Further information is requested label Oct 9, 2019
@375gnu
Copy link
Member

375gnu commented Oct 9, 2019

Qt has longstanding issues with transparent images. It doesn't support 8bit transparency, so in some cases we have solid black colour instead of transparency. If somebody fixes our Qt splashscreen, we'll consider including one of those images.

@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Oct 9, 2019

The current splash image also has transparency. Are you saying it will need to change?

@375gnu
Copy link
Member

375gnu commented Oct 10, 2019

@SevenSpheres yes, but the current image has quite small transparent border, while Alexell's one has large regions. So with the current one this issue is not much noticeable.

@SevenSpheres
Copy link
Contributor Author

I don't see much of a difference in the size of the transparent regions. Doesn't really matter what splash image is used of course.

@375gnu
Copy link
Member

375gnu commented Oct 11, 2019

I'll check it, I have that issue on my computer.

@375gnu
Copy link
Member

375gnu commented Oct 11, 2019

We can vote on the forum:) And check Alexell's license for those images.

@Alexell
Copy link
Contributor

Alexell commented Oct 11, 2019

@375gnu if necessary, you can use these images. They were made specifically for Celestia.

@375gnu
Copy link
Member

375gnu commented Oct 11, 2019

@Alexell we need a clear license. I propose the same license we use for the code - GPLv2 or later

@Alexell
Copy link
Contributor

Alexell commented Oct 11, 2019

@375gnu ok i agree

@SevenSpheres
Copy link
Contributor Author

Actually, why not add a line like this to celestia.cfg:
SplashImage "splash.png"
Then the user can choose what splash image they want without having to rename/replace any files.
Celestia could even install with multiple images for the user to choose from.

It would also be nice to be able to put other windows in front of the splash screen.

@375gnu
Copy link
Member

375gnu commented Oct 12, 2019 via email

@SevenSpheres
Copy link
Contributor Author

Why? The main idea of splash screens is that a user sees that an
application is working while it's not ready to interact with a user.

Because if you're using Celestia with lots of addons, it takes a long time to load, and since the splash screen is always in front you can't do anything in other windows.

@375gnu
Copy link
Member

375gnu commented Oct 12, 2019

but it's not ready yet, what will you do?

@SevenSpheres
Copy link
Contributor Author

@SevenSpheres SevenSpheres changed the title Alexell's splash image Celestia splash screen Oct 13, 2019
@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Oct 13, 2019

Renamed this issue because it's no longer about Alexell's image...

Anyway 6 people (including pirogronian) agree with me that the splash screen shouldn't always be in front. FarGetaNik also notes that the latest 1.7 doesn't display the splash screen at all, but I assume this will be fixed?

@pirogronian
Copy link
Contributor

On my machine (Linux) there is no problem: splash screen can be hidden by other windows.

@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Oct 13, 2019

I guess I'll wait until the splash screen is restored in the 1.7 Windows version and then see if this has been fixed. Edit: I see a pull request has been opened

@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Oct 19, 2019

I'm not really sure what to do with this thread. Here's a checklist of things I've suggested doing; should I split them into other issues instead?

  • Make it possible to override splash in Windows version
  • Restore splash in QT version
  • Add SplashImage line to celestia.cfg
  • Add more splash images (e.g., Alexell's)

@375gnu
Copy link
Member

375gnu commented Oct 19, 2019

in Qt version splash is searched in c:/Program Files (x86)/celestia/share/celestia/splash/splash.png, i.e. where celestia should be installed

@375gnu
Copy link
Member

375gnu commented Oct 19, 2019

let's keep your suggestions here and reference it from pull requests

@SevenSpheres
Copy link
Contributor Author

in Qt version splash is searched in c:/Program Files (x86)/celestia/share/celestia/splash/splash.png, i.e. where celestia should be installed

In the QT version the splash screen is not displayed. Also, on Windows the above directory structure does not exist; splash.png is in the main Celestia directory. Should it be in share/celestia/splash instead?

@375gnu
Copy link
Member

375gnu commented Oct 19, 2019

Should it be in share/celestia/splash instead?

yes

@SevenSpheres
Copy link
Contributor Author

I created a directory share/celestia/splash and moved splash.png there. There is no change in the 1.7 QT version (i.e., still no splash screen). In the 1.7 Win version the splash screen is gone.

@375gnu
Copy link
Member

375gnu commented Oct 19, 2019

ok, we'll need to handle it in both frontends

@SevenSpheres
Copy link
Contributor Author

So in the latest build (Win version) the splash screen can be overridden, but it doesn't work right. When another window is brought in front of the splash, instead of the splash going behind just that one window, it goes all the way to the back, i.e. behind all windows.

@375gnu
Copy link
Member

375gnu commented Nov 3, 2019

None of us uses windows. See #322 . Don't expect native win frontend to work 100% correctly.

@SevenSpheres
Copy link
Contributor Author

The splash image appears to have been restored in the Qt version! 👍

@375gnu
Copy link
Member

375gnu commented Jun 6, 2021

regarding the splashimageoption. the problem is that some interfaces (qt, win32) create splash image before they start loading different data, only gtk first creates CelestiaCore which loads celestia.cfg before creating a splash. personally i'm not eager not rewrite qt ui (it looks like fixing win32 is easy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants