This repository was archived by the owner on Sep 12, 2022. It is now read-only.
Activemodel7 couchbase ruby client #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
CedricCouton
commented
Jun 23, 2022
CedricCouton
commented
simkim
reviewed
Jun 24, 2022
| CouchbaseOrm.logger.debug "Data - Get #{id}" | ||
| !bucket.get(id, quiet: true).nil? | ||
| CouchbaseOrm.logger.debug "Data - Exists? #{id}" | ||
| collection.exists(id).exists |
simkim
reviewed
Jun 24, 2022
| alias_method :has_key?, :exists? | ||
| end | ||
|
|
||
| class MismatchTypeError < RuntimeError; end |
simkim
reviewed
Jun 24, 2022
| def touch(**options) | ||
| CouchbaseOrm.logger.debug "Data - Touch #{@__metadata__.key}" | ||
| res = self.class.bucket.touch(@__metadata__.key, async: false, **options) | ||
| res = self.class.collection.touch(@__metadata__.key, async: false, **options) |
There was a problem hiding this comment.
replace all **options by encapsulating them with Options
simkim
reviewed
Jun 24, 2022
| else | ||
| false | ||
| end | ||
| records = quiet ? collection.get_multi(ids) : collection.get_multi!(ids) |
simkim
reviewed
Jun 24, 2022
| nil | ||
| end | ||
|
|
||
| def get_multi!(*ids, **options) |
There was a problem hiding this comment.
should add a test where first id is valid but not second
simkim
reviewed
Jun 24, 2022
|
|
||
| # Clean up record if the id doesn't exist | ||
| self.bucket.delete(key, quiet: true) | ||
| self.collection.remove(key) |
test migration to actionmodel7 + rails7
GitHub actions
CedricCouton
force-pushed
the
activemodel7-couchbase-ruby-client
branch
from
0fd05cc to
922dbb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.