Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quote fix #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ParzivalAFK
Copy link

Issue #4 was right. There was a breaking bug which did not convert any string with a double quote in it to an escaped double quote making the output python file not able to run due to python syntax issues. I have properly fixed this in both the .py and .js files to work accurately.

Issue #4 should be able to be closed now.

Thank you for the great tool!

@ParzivalAFK
Copy link
Author

Oh, I forgot to mention that I changed the exit prompt in your python script from "press any key" to just telling the end user to press enter or return.

After I pushed a few keys and it did not exit I figured I needed to push enter and I was right.
Since you are using an input() python function you must push enter regardless of what characters you typed.


If you do want to maintain the "press any key" you might want to do something like this:

WINDOWS:

import msvcrt # To capture key press
print("\nConversion complete!\n\nPress any key to close.") # Your line
msvcrt.getch()  # Waits for a key press

APPLE/LINUX TYPE OS:

import curses

def main(stdscr):
    stdscr.clear()
    stdscr.addstr("\nConversion complete!\n\nPress any key to close.")
    stdscr.refresh()
    stdscr.getch()

curses.wrapper(main)

... And really none of this really matters nobody should be that picky and if they have enough knowledge to program in python or a rubber ducky they should be able to figure to push enter on their own. You have a great script and I appreciate the time saved for me not having to make my own for my students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant