Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paintroid-726 : Fix project overflow menu button color #63

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vishad-tyagi
Copy link
Contributor

@vishad-tyagi vishad-tyagi commented Apr 2, 2024

Ticket: Paintroid-726
https://catrobat.atlassian.net/browse/PAINTROID-726

New Features and Enhancements

  • Added optional iconColor property to project_overflown_menu

Refactorings and Bug Fixes

  • In landing_page set ProjectOverflowMenu color to onBackground from color_schemes

Simulator

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@vishad-tyagi vishad-tyagi requested a review from msesko April 21, 2024 08:29
Copy link
Contributor

@msesko msesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now, but same as with other PR, let's wait for theming to be handed. Should be done on Tuesday on the teamday that we have

@juliajulie95
Copy link
Contributor

Please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants