Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paintroid-638 : Add a placeholder name when saving #50

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

vishad-tyagi
Copy link
Contributor

@vishad-tyagi vishad-tyagi commented Feb 29, 2024

Ticket
https://catrobat.atlassian.net/browse/PAINTROID-638
Paintroid-638 : Add a placeholder name when saving

Description
If the user saves a project there should be a placeholder in image name like in Piantroid Android.
For the "Save image" dialog, the placeholder should be "image[number]" with the number being the next available number not yet taken in the files.
If I create my first image it should say "image1", when I save this and start a new image it should say "image2".

Same for the projects, here the placeholder should be "project[number]"

New Features and Enhancements

  • New Features and Enhancements

Refactorings and Bug Fixes

  • Refactorings and Bug Fixes

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@vishad-tyagi vishad-tyagi changed the title Add a placeholder name when saving Paintroid-638 : Add a placeholder name when saving Feb 29, 2024
@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 I apologize for the inconvenience. I have identified the issue and am currently implementing a fix. I added print statements for my self-debugging. I will fix ASAP and commit the changes.

@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 There is a problem in the unit test case
final textFormField = find.widgetWithText(TextFormField, 'Project name');
expect(textFormField, findsOneWidget);
this line in landing_page_test.dart is checking for text Project name but finds autosuggested names like Project1, Project2 etc, which is placeholder names. widgetWithText is very strict with comparing text so a text regex is not a solution. So can I edit this line in this unit test?

@juliajulie95
Copy link
Contributor

@vishad-tyagi You can definitely change a test if the functionality changed

@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 ok I will make changes in test case and commit them ASAP

@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 Kindly check once more, all test cases are passed on my local machine. I have removed the self-debugging print statements

@vishad-tyagi vishad-tyagi requested a review from msesko April 21, 2024 08:30
@juliajulie95
Copy link
Contributor

Please resolve conflicts

@vishad-tyagi
Copy link
Contributor Author

@juliajulie95 Can I continue to contribute even when I am not selected for GSOC ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants