Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomised usage for matching-ws #1375

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

djtfmartin
Copy link
Contributor

The main work here is additional content for the web services to avoid downstream processes (pipelines) needing to re-parse scientific names. This is described in this issue: #1350

Also includes fixes for:

Also includes fixes for prefix mapping and metadata loading.

* CatalogueOfLife/data#719
* CatalogueOfLife/data#722
Work for
* #1350
Fixes for prefix mapping and metadata loading
@djtfmartin djtfmartin assigned djtfmartin and mdoering and unassigned djtfmartin Nov 5, 2024
@djtfmartin djtfmartin marked this pull request as draft November 5, 2024 16:16
Copy link

gitguardian bot commented Nov 5, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14107617 Triggered Generic Password addadde dao/src/test/java/life/catalogue/es/EsSetupRule.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mdoering mdoering marked this pull request as ready for review November 5, 2024 16:22
@mdoering mdoering merged commit f89f812 into master Nov 5, 2024
1 check failed
@djtfmartin djtfmartin deleted the feature/include_atomised_usage_pr branch December 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants