Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 9.12.0.78982 to 9.21.0.86780 #118

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 11, 2024

Bumps SonarAnalyzer.CSharp from 9.12.0.78982 to 9.21.0.86780.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.21

New Rules

  • 8771 - [C#] New rule S6678: Use PascalCase for named placeholders
  • 8770 - [C#] New rule S6674: Log message template should be syntactically correct
  • 8768 - [C#] New rule S2629: Logging templates should be constant
  • 8767 - [C#] New rule S6677: Named placeholders should be unique
  • 8766 - [C#] New rule S6667: Exceptions should be passed as an argument when logging in a catch clause
  • 8765 - [C#] New rule S6668: Logging arguments should be passed to the correct parameter

Improvements

  • The following rules were promoted to the SonarWay profile: S127, S1244, S1696, S1192, S1994, S2701, S2955

Bug Fixes

  • 8787 - [C#] Fix AD0001: SonarAnalyzer.Rules.CSharp.SymbolicExecutionRunner throws an exception on unknown Numeric Constraints

False Positive

  • 8823 - [C#] Fix S2701 FP: avoid raising for xUnit Assert.True()
  • 6772 - [C#] Fix S4507 FP: Error raised on .NET 7 although the debug feature is deactivated

9.20

Hey everyone!

This release brings a vast number of improvements. The main focus lies on improving the capabilities of our Symbolic Execution engine, which results in much more accurate findings. The biggest visible impact is a significant reduction in false positives around loops for the rules S2583 and S2589.

And a big thank you to @​rcatley for their external contribution!

Bug Fixes

  • 8642 - [C#] Exception in SonarAnalyzer.Rules.CSharp.SymbolicExecutionRunner

False Positive

  • 8678 - [C#, VB.NET] Fix S2583 FP: Variable Updated in Catch Block
  • 8028 - [C#, VB.NET] Fix S2583 FP: Loop with manually incremented counter
  • 8449 - [C#, VB.NET] Fix S2589 FP: Change this condition so that it does not always evaluate to 'True'
  • 8495 - [C#, VB.NET] Fix S2583/S2589 FP: Return inside lock and using causes FP after the block
  • 8428 - [C#, VB.NET] Fix S2583/S2589 FP: For loop with Array.Length
  • 8483 - [C#, VB.NET] Fix S4158 FP: Should not report on HashSet.UnionWith for readonly fields.
  • 8739 - [C#] Fix S4049 FP: Do not raise on methods with generic parameters
  • 8638 - [C#] Fix S2386 & S3887 FP: should not be raised for FrozenDictionary and FrozenSet
  • 8611 - [C#] Fix S2372 FP: Add support for method invocations (@​rcatley)
  • 8567 - [C#] Fix S2325 FP: Primary Constructor Support

False Negative

  • 8486 - [C#] Fix S2589 FN: Tuple binary operations (comparison)

Improvements

  • 8010 - [C#, VB.NET] S2589: Improve message in the case of null propagating operator
  • 7866 - [C#, VB.NET] SE: Allow collection tracking even when S4158 is not active
  • 8499 - [C#] SE: Learn number constraints from relational pattern
  • 8651 - Update RSPEC before 9.20 release

9.19

Hello,

small release to enhance the deprecation warning before SonarQube v.10.4, explicitly notifying users analyzing with MSBuild 14 that it's no longer supported while maintaining the deprecation status for MSBuild 15. Furthermore, we've also introduced three improvements to our rules:

... (truncated)

Commits
  • b05eb80 Rule S6668: Handle the rule exceptions (#8848)
  • afbce35 Update RSPEC for 9.21 Release (#8838)
  • 88b80ab Improve S6678: Change primary and secondary locations (#8836)
  • 7ae6c9a Promote 7 rules to SonarWay (#8806)
  • c0d6a61 New rule S6674: Log message template should be syntactically correct (#8818)
  • 4fe2a8b New rule S6668: Logging arguments should be passed to the correct parameter (...
  • b0d5ee0 .NET ITs: Move .NET5 code to CSharpLatest (#8808)
  • 95a7dca Fix S2701 FP: avoid raising for xUnit Assert.True() (#8823)
  • beb30d9 S125: Add FP Repro for #8819 (#8821)
  • f96478a Template rules update after peach validation part#2 (#8820)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.12.0.78982 to 9.21.0.86780.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.12.0.78982...9.21.0.86780)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 11, 2024
Copy link

dbml.NET test report - 2024-03-11

Run Summary

Overall Result: ⚠️ Indeterminate
Pass Rate: 99.8%
Run Duration: < 1ms
Date: 2024-03-11 13:11:37 - 2024-03-11 13:11:49
Total Tests: 1018

✔️ Passed ❌ Failed ⚠️ Skipped
1016 0 2
99.8% 0% 0.2%

Unit Tests

Group Result: ⚠️ Indeterminate

Pass Rate: 99.8%

Tests: 1018

Duration: < 1ms

Results:
✔️ Passed (1016)
Test Duration
⚠️ Skipped for performance reasons! < 1ms
⚠️ Skipped (2)
Test Duration
⚠️ DbmlNet.Tests.Unit.CodeAnalysis.Syntax.ParserTests.Parse_SingleFieldIndexDeclaration_With_QuotationMarksString_Name Source:
DbmlNet.Tests.Unit.CodeAnalysis.Syntax.ParserTests.Parse_SingleFieldIndexDeclaration_With_QuotationMarksString_Name
< 1ms
⚠️ DbmlNet.Tests.Unit.CodeAnalysis.Syntax.ParserTests.Parse_SingleFieldIndexDeclaration_With_SingleQuotationMarksString_Name Source:
DbmlNet.Tests.Unit.CodeAnalysis.Syntax.ParserTests.Parse_SingleFieldIndexDeclaration_With_SingleQuotationMarksString_Name
< 1ms

Copy link

Summary - dbml.NET

Summary
Generated on: 03/11/2024 - 13:12:14
Coverage date: 03/11/2024 - 13:11:49
Parser: MultiReport (2x Cobertura)
Assemblies: 1
Classes: 94
Files: 93
Line coverage: 89.4% (2511 of 2807)
Covered lines: 2511
Uncovered lines: 296
Coverable lines: 2807
Total lines: 8269
Branch coverage: 88.2% (967 of 1096)
Covered branches: 967
Total branches: 1096
Method coverage: Feature is only available for sponsors

Coverage

DbmlNet - 89.4%
Name Line Branch
DbmlNet 89.4% 88.2%
DbmlNet.CodeAnalysis.Diagnostic 100%
DbmlNet.CodeAnalysis.DiagnosticBag 98.4%
DbmlNet.CodeAnalysis.Syntax.BacktickExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.BlockStatementSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.CallExpressionSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.ColumnDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.ColumnIdentifierClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.ColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.ColumnSettingListSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.ColumnTypeClause 100%
DbmlNet.CodeAnalysis.Syntax.ColumnTypeIdentifierClause 100%
DbmlNet.CodeAnalysis.Syntax.ColumnTypeParenthesizedIdentifierClause 100%
DbmlNet.CodeAnalysis.Syntax.CompilationUnitSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.CompositeIndexDeclarationSyntax 94.7% 100%
DbmlNet.CodeAnalysis.Syntax.DatabaseProviderProjectSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.DefaultColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.EnumDeclarationSyntax 100%
DbmlNet.CodeAnalysis.Syntax.EnumEntryDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.EnumEntrySettingClause 100%
DbmlNet.CodeAnalysis.Syntax.EnumEntrySettingListSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.EnumIdentifierClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.ExpressionStatementSyntax 100%
DbmlNet.CodeAnalysis.Syntax.ExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.GlobalStatementSyntax 100%
DbmlNet.CodeAnalysis.Syntax.HeaderColorTableSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.IncrementColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.IndexDeclarationStatementSyntax 100%
DbmlNet.CodeAnalysis.Syntax.IndexesDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.IndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.IndexSettingListSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.Lexer 97.9% 98.9%
DbmlNet.CodeAnalysis.Syntax.LiteralExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.MemberSyntax 100%
DbmlNet.CodeAnalysis.Syntax.NameExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.NameIndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NoteColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NoteDeclarationSyntax 100%
DbmlNet.CodeAnalysis.Syntax.NoteEnumEntrySettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NoteIndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NoteProjectSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NotNullColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NullColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.NullExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.ParenthesizedExpressionSyntax 100%
DbmlNet.CodeAnalysis.Syntax.Parser 99.7% 97.9%
DbmlNet.CodeAnalysis.Syntax.PkColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.PkIndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.PrimaryKeyColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.PrimaryKeyIndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.ProjectDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.ProjectSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.ProjectSettingListSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.RelationshipColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.RelationshipConstraintClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.RelationshipDeclarationSyntax 100%
DbmlNet.CodeAnalysis.Syntax.RelationshipLongFormDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.RelationshipShortFormDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.SeparatedSyntaxList 100%
DbmlNet.CodeAnalysis.Syntax.SeparatedSyntaxList`1 71.4% 33.3%
DbmlNet.CodeAnalysis.Syntax.SingleFieldIndexDeclarationSyntax 91.6% 100%
DbmlNet.CodeAnalysis.Syntax.StatementSyntax 100%
DbmlNet.CodeAnalysis.Syntax.SyntaxFacts 100% 100%
DbmlNet.CodeAnalysis.Syntax.SyntaxNode 10.9% 0%
DbmlNet.CodeAnalysis.Syntax.SyntaxToken 100% 66.6%
DbmlNet.CodeAnalysis.Syntax.SyntaxTree 66.6% 60%
DbmlNet.CodeAnalysis.Syntax.SyntaxTrivia 75% 0%
DbmlNet.CodeAnalysis.Syntax.SyntaxWalker 54.2% 59.3%
DbmlNet.CodeAnalysis.Syntax.TableAliasClause 100%
DbmlNet.CodeAnalysis.Syntax.TableDeclarationSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.TableIdentifierClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.TableSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.TableSettingListSyntax 100% 100%
DbmlNet.CodeAnalysis.Syntax.TypeIndexSettingClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.UniqueColumnSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.UniqueIndexSettingClause 100%
DbmlNet.CodeAnalysis.Syntax.UnknownColumnSettingClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.UnknownEnumEntrySettingClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.UnknownIndexSettingClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.UnknownProjectSettingClause 100% 100%
DbmlNet.CodeAnalysis.Syntax.UnknownTableSettingClause 100% 100%
DbmlNet.CodeAnalysis.Text.SourceText 96% 95.4%
DbmlNet.CodeAnalysis.Text.TextLine 100%
DbmlNet.CodeAnalysis.Text.TextLocation 56.2% 0%
DbmlNet.CodeAnalysis.Text.TextSpan 75% 33.3%
DbmlNet.CodeAnalysis.Text.TextUnindenter 95.6% 94.4%
DbmlNet.Domain.DbmlColumnIdentifier 100% 100%
DbmlNet.Domain.DbmlDatabase 100%
DbmlNet.Domain.DbmlDatabaseMaker 97.5% 90.9%
DbmlNet.Domain.DbmlProject 100% 100%
DbmlNet.Domain.DbmlTable 100% 100%
DbmlNet.Domain.DbmlTableColumn 100% 66.6%
DbmlNet.Domain.DbmlTableIndex 100%
DbmlNet.Domain.DbmlTableRelationship 100%
DbmlNet.IO.TextWriterExtensions 0% 0%

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 25, 2024

Superseded by #122.

@dependabot dependabot bot closed this Mar 25, 2024
@dependabot dependabot bot deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.21.0.86780 branch March 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants