Migration from CMake to Meson #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace RNG with fragmites::random Update version header and version number Replace <> with "" for including headers in include/dawg Add .clang-format (Google styleguide) Format modified files according to .clang-format
jgarciamesa
commented
May 12, 2022
| root_seq.at(i), root_seq.at(i + 1), | ||
| root_seq.at(i + 2))), | ||
| 0, 0); | ||
| if(residues.back().data() > 63) { |
There was a problem hiding this comment.
@reedacartwright the old comparison was residues.back().data() == -1 but that compares and unsigned int to -1. I updated it to this because to my understanding triplet_to_codon should return a number [0,63]. I would like your confirmation for this change.
jgarciamesa
commented
May 12, 2022
Comment on lines
+148
to
+158
| template <typename _It> | ||
| void seed(_It first, _It last) { | ||
| fragmites::random::seed_seq_t seed(first, last); | ||
| maxx.Seed(seed); | ||
| } | ||
| template <typename T> | ||
| void seed(T t) { | ||
| maxx.Seed(t); | ||
| } | ||
|
|
||
| void auto_seed_seq() { maxx.Seed(fragmites::random::auto_seed_seq()); } |
There was a problem hiding this comment.
@reedacartwright generate seed using fragmites::random.
eli-schwartz
suggested changes
May 13, 2022
jgarciamesa
commented
May 13, 2022
Comment on lines
+163
to
+170
| dawg::matic simulation; | ||
| // if a seed was specified, use it | ||
| if(arg.seed != 0) { | ||
| simulation.seed(arg.seed); | ||
| } else if(!glopts.sim_seed.empty()) { | ||
| simulation.seed(glopts.sim_seed.begin(), glopts.sim_seed.end()); | ||
| } else { | ||
| simulation.auto_seed_seq(); |
There was a problem hiding this comment.
Changed the variable name to simulation and added the else statement to pick a random seed if no user specified ones.
jgarciamesa
commented
May 13, 2022
|
|
||
| segment_vector configs; | ||
| // mutt maxx; | ||
| random_t maxx; |
There was a problem hiding this comment.
Changed maxx to be of class fragmites::random::Random.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace CMake build framework with Meson, addresses #68.
Replace random number generator with fragmites::random, addresses #70.
Update version header and version number.
Replace syntax from <> to "" when including non system headers.
Add .clang-format (Google style guide) and format modified files accordingly.
Remove deprecated options from doxygen's configuration file.
Add contribution folder with CLI11, doctest, and rapidyaml libraries (not yet in use).