Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding YAML support #24

Closed
wants to merge 2 commits into from
Closed

Adding YAML support #24

wants to merge 2 commits into from

Conversation

zmertens
Copy link
Contributor

@zmertens zmertens commented Oct 15, 2016

This change is intended to add basic functionality to parse YAML files addressing issue #23 .

  • I updated dawg.txt to try to explain what the YAML parser expects.
  • The issue that I was having with the recombination example had nothing to do with the parser and was just a very subtle spelling error when I made the yaml test file.
  • I think -DBUILD_EXTERNAL_PROJECTS:BOOL=ON needs to be on for Jenkines in order to pull down YAML-CPP and build (which should be supported by the ExternalDeps.cmake
  • Did not add the part deletion functionality

yaml-callgrinds.tar.gz

@dng-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@reedacartwright
Copy link
Collaborator

Jenkins, okay to test

@zmertens
Copy link
Contributor Author

zmertens commented Oct 18, 2016

I updated the branch, a couple important changes from the previous branch:

  • I added to the parse_test a test case to test the basic-dna.yaml file.
  • I added pre-processor definitions to strip out yaml-cpp references from the CPP if the yaml-cpp library is not found
  • I made some minor changes to how the YAML is parsed, namely, changing the name of some of the iterators in parse_yaml in trick_parse.h file (the it, itt, and ittt family was getting confusing), and also added a to_lower function call for verifying the file extension in parse.cpp
  • I squashed the commits down

zryan3 and others added 2 commits March 1, 2017 16:34
 - Closes #23
 - Add basic-dna example in YAML format
 - Dawg Trick can detect YAML using file extension
 - Add Unit tests to verify equality of parsing outputs between
traditional trick files and YAML files
 - Add preprocessor definition check for yaml-cpp lib in parse.cpp
, trick.h, and trick_parse.h
 - Add option to build and link YAML-CPP with CMAKE (BUILD_EXTERNAL_PROJECTS=ON)
 - Update dawg.txt and readme.txt to describe YAML input formats
@zmertens zmertens closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants