Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Unit Test Suite for the Matlab Toolbox #1665

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ssun30
Copy link
Contributor

@ssun30 ssun30 commented Jan 23, 2024

Changes proposed in this pull request

  • Added Kinetics class tests for all methods and properties currently implemented

If applicable, fill in the issue number this pull request is fixing

Updates to Cantera/enhancements#177

If applicable, provide an example illustrating new features this pull request is introducing

Added tests for rates of progress, rate constants, species rates, and thermodynamic values.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
Copy link
Member

@ssun30 and @rwest ... what are the current plans on this PR and Cantera/enhancements#177? With the old MATLAB toolbox removed, the next Cantera version will only provide for the experimental toolbox.

@ssun30
Copy link
Contributor Author

ssun30 commented Jun 22, 2024

@ssun30 and @rwest ... what are the current plans on this PR and Cantera/enhancements#177? With the old MATLAB toolbox removed, the next Cantera version will only provide for the experimental toolbox.

Hi Ingmar, finishing the test suite is back on our to-do list and we were aiming to complete it by the end of the month. There is a slight delay so maybe the first week of July we shall have all the unit tests ready.

@ssun30 ssun30 force-pushed the matlab_patches branch 3 times, most recently from 8c98850 to 3acff45 Compare February 13, 2025 02:13
@ssun30 ssun30 marked this pull request as ready for review February 13, 2025 04:33
@ssun30
Copy link
Contributor Author

ssun30 commented Feb 13, 2025

After a year of hiatus this PR is finally ready for review. Thanks to support from Mathworks the plan to make the Matlab toolbox official is back on track.

@ssun30 ssun30 changed the title Complete Tests for Kinetics Class for the Matlab Toolbox Complete Unit Test Suite for the Matlab Toolbox Feb 19, 2025
@ssun30
Copy link
Contributor Author

ssun30 commented Feb 19, 2025

Checklist for all unit tests (that can be implemented in MATLAB)

  • ThermoPhase
  • Pure Fluid Phases
  • Kinetics
  • Transport
  • Functors
  • Equilibrium
  • Mixture
  • Reactors and Reactor Networks
  • 1D domains

@ssun30
Copy link
Contributor Author

ssun30 commented Feb 20, 2025

@ischoegl @speth It seems that I don't have write access to the repo and thus could not request reviews for this PR. Could you check whether that's true and grant me access?

Added ImportPhases Method
Incompatibility Introduced by MATLAB's built-in
Intel MKL library
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ssun30 ... thanks for getting back to this! From my side, this looks mostly good to go (despite a minor nit that some newlines at file endings are missing). I did notice that the MATLAB CI run wasn't completed successfully, though.

Overall, it's great to have some of this covered, especially as the plan is to move towards replacing the current CLib with an autogenerated CLib (see Cantera/enhancements#220). Once this is in place, it will be relatively easy to expose parts that are currently missing from the MATLAB API (e.g. Reaction, Species, ReactionRate, SolutionArray, etc.). One thing that may also be necessary is a MATLAB equivalent to AnyMap to access the serialization interface - I believe that there's a new dictionary that was introduced in R2022b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants