supermodel: add version 0.3a-git-f9cb795 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changes look good. Wait for review from human collaborators. supermodel
|
Calinou
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Thanks!
as Supermodel is hardcoded to load configuration files relative to the executable.
In the future, someone should look into modifying Supermodel so that it detects its executable path, and load files relative to that path instead. This would allow starting Supermodel regardless of the CWD, removing the need for a launcher script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added supermodel package version 0.3a-git-f9cb795.
The versioning string for the newest development versions of Supermodel is random, but the Supermodel download page sorts the builds in order of newest, so we only need to capture the first match to get the newest version.
Supermodel in Scoop has to be run using a wrapper script that temporarily sets the working directory to the executable location, as Supermodel is hardcoded to load configuration files relative to the executable. As far as I could see, there are no Scoop options yet for being able to set the working directory of an entry in the bin field.
Closes #681