Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demulshooter: Update to version 12 #1109

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

RavenMacDaddy
Copy link
Contributor

Manual update to version 12; the autoupdate section would need $cleanVersion at the end, while more likely than not, $version will continue to work going forward, since everything points to the next version being called 12.1, with the URL following that.

Copy link
Contributor

Your changes do not pass checks.

demulshooter

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Calinou Calinou added the package update A package needs to be updated label Mar 20, 2024
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Should be good to merge after fixing CI.

@RavenMacDaddy
Copy link
Contributor Author

RavenMacDaddy commented Mar 21, 2024

Thanks!

Should be good to merge after fixing CI.

CI?

EDIT:

image

This right? My interpretation is that you're waiting for other code to merge according to some sort of schedule.

@Calinou
Copy link
Owner

Calinou commented Mar 24, 2024

This right? My interpretation is that you're waiting for other code to merge according to some sort of schedule.

Yes, look at the Checks tab of the pull request as 1 check is currently failing: #1109 (comment)

@RavenMacDaddy
Copy link
Contributor Author

Since the whole thing is about a manual update while waiting for release 12.1, you're free to either close or merge it as is — your call. :)

Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 84141d5 into Calinou:master Mar 28, 2024
2 of 3 checks passed
@RavenMacDaddy RavenMacDaddy deleted the patch-36 branch March 28, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest-fix-needed package update A package needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants